Skip to content

Split packages for better customization and remove test infrastructure #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericbsd merged 2 commits into from
Nov 29, 2025
Merged

Split packages for better customization and remove test infrastructure #251

ericbsd merged 2 commits into from
Nov 29, 2025

Conversation

@ericbsd
Copy link
Member

@ericbsd ericbsd commented Nov 29, 2025 •
edited by sourcery-ai bot
Loading

Reorganize package lists to allow desktop-specific customization:

  • Move desktop-specific packages (evolution, rhythmbox, shotwell, slick-greeter, system-config-printer, vlc, gnome-keyring) from common to individual desktop package lists (mate, xfce, gershwin)
  • Add gbi to desktop-specific lists (mate, plasma) instead of common
  • Add zsh to common packages

Simplify mate_oem package list for installation testing:

  • Remove gbi from mate_oem to enable testing of install-station and setup-station without the installer
  • Add install-station and setup-station packages
  • Remove redundant packages now inherited from common
  • Note: mate_oem will be removed once testing is complete

Remove test/test_base infrastructure:

  • Delete packages/test and packages/test_base
  • Delete desktop_config/test.sh
  • Remove -t test option from build.sh
  • Remove conditional test_base logic from base() function

This restructuring makes it easier to customize package sets per
desktop environment and enables proper testing of the installation
workflow.

Summary by Sourcery

Reorganize desktop package definitions and simplify test-related configurations by consolidating common packages and removing the obsolete test build path.

Enhancements:

  • Split desktop-specific package lists so DE-specific applications are no longer shared via the common package set and add zsh to the common packages.
  • Adjust mate_oem and other desktop package lists to better support installation workflow testing without relying on the full installer.
  • Simplify base package selection logic in the build script by removing conditional handling for a separate test desktop.

Build:

  • Remove the test build mode flag and related logic from the build script so only standard desktop/build-type combinations are supported.

Tests:

  • Delete the legacy test/test_base package lists and related desktop test configuration script now that the dedicated test desktop is no longer used.

@ericbsd
Split packages for better customization and remove test infrastructure
46b5b86 
  Reorganize package lists to allow desktop-specific customization:
  - Move desktop-specific packages (evolution, rhythmbox, shotwell,
    slick-greeter, system-config-printer, vlc, gnome-keyring) from
    common to individual desktop package lists (mate, xfce, gershwin)
  - Add gbi to desktop-specific lists (mate, plasma) instead of common
  - Add zsh to common packages

  Simplify mate_oem package list for installation testing:
  - Remove gbi from mate_oem to enable testing of install-station
    and setup-station without the installer
  - Add install-station and setup-station packages
  - Remove redundant packages now inherited from common
  - Note: mate_oem will be removed once testing is complete

  Remove test/test_base infrastructure:
  - Delete packages/test and packages/test_base
  - Delete desktop_config/test.sh
  - Remove -t test option from build.sh
  - Remove conditional test_base logic from base() function

  This restructuring makes it easier to customize package sets per
  desktop environment and enables proper testing of the installation
  workflow.
@ericbsd ericbsd requested review from a team as code owners November 29, 2025 18:23
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 29, 2025 •
edited
Loading

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR restructures package lists to be per-desktop instead of relying on a shared test/common setup, simplifies the mate_oem package set for installation workflow testing, and removes all test-specific build and package infrastructure from the build pipeline.

File-Level Changes

Change Details Files
Remove test-specific build mode and always use the standard base/vital package lists.
  • Drop the -t test CLI flag from the build script help text and option parsing.
  • Remove the case branch that set desktop=test and build_type=test based on -t.
  • Simplify the base() function to always read packages/base and packages/vital/base, removing conditional logic for test_base.
 build.sh
Restructure desktop package lists so that desktop-specific applications are defined per desktop instead of in the common package list.
  • Move desktop-specific applications (e.g., evolution, rhythmbox, shotwell, slick-greeter, system-config-printer, vlc, gnome-keyring) out of the shared package list into the appropriate desktop package lists (mate, xfce, gershwin).
  • Add the installer frontend package gbi to desktop-specific lists (mate, plasma) instead of the common list.
  • Add zsh to the shared common package list so all desktops inherit it.
 packages/common
packages/mate
packages/xfce
packages/gershwin
packages/plasma
Adjust mate_oem package list to support installation workflow testing without bundling the installer itself.
  • Remove gbi from the OEM desktop package list to allow testing install-station and setup-station independently of the installer.
  • Add install-station and setup-station packages to the OEM package list.
  • Drop packages that are now inherited from the shared common package list.
  • Document that the OEM package list is temporary and slated for removal after testing.
 packages/mate_oem
Remove legacy test-specific package and desktop configuration infrastructure.
  • Delete the test desktop configuration script used for test builds.
  • Delete the test_base package list and any associated test package directories.
  • Rely solely on the standard base/vital package lists for all builds.
 desktop_config/test.sh
packages/test_base
packages/test
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ghostbsd-bot ghostbsd-bot moved this to In Review in Development Tracker Nov 29, 2025
sourcery-ai[bot]
sourcery-ai bot reviewed Nov 29, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd mentioned this pull request Nov 29, 2025
Closed
11 tasks
@ericbsd ericbsd merged commit 882ee00 into master Nov 29, 2025
2 checks passed
@ericbsd ericbsd deleted the install-setup branch November 29, 2025 18:48
@ericbsd ericbsd moved this from In Review to Done in Development Tracker Jan 15, 2026
@ericbsd ericbsd self-assigned this Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

+1 more reviewer

@pkgdemon pkgdemon pkgdemon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ericbsd ericbsd

Labels

None yet

Projects

Development Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericbsd @pkgdemon